Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: BUG-FIX, pass in nav callback to exploration / layer-info-modal #1335

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

sandrahoang686
Copy link
Collaborator

@sandrahoang686 sandrahoang686 commented Dec 17, 2024

THIS IS TO FIX A BUG 🐛 🐞 look at linked thread...
Related Ticket: US-GHG-Center/veda-config-ghg#689
Related Thread for GHG https://developmentseed.slack.com/archives/C03LGTM2SSH/p1734459208927079?thread_ts=1734456710.644149&cid=C03LGTM2SSH

DEPLOY PREVIEW FOR GHG that points to this commit US-GHG-Center/veda-config-ghg#690

Description of Changes

{Update with description of changes made in this pull request}

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit ea766a1
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6761e99c94b7d7000859391b
😎 Deploy Preview https://deploy-preview-1335--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 changed the title nav callback for exploration for layer-info-modal chore: nav callback for exploration for layer-info-modal Dec 17, 2024
@sandrahoang686 sandrahoang686 marked this pull request as ready for review December 17, 2024 21:03
@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented Dec 17, 2024

DEPLOY PREVIEW FOR GHG that points to this commit US-GHG-Center/veda-config-ghg#690

@sandrahoang686 sandrahoang686 changed the title chore: nav callback for exploration for layer-info-modal chore: bug-fix, nav callback for exploration for layer-info-modal Dec 17, 2024
@sandrahoang686 sandrahoang686 changed the title chore: bug-fix, nav callback for exploration for layer-info-modal chore: BUG-FIX, pass in nav callback to exploration / layer-info-modal Dec 17, 2024
Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for working on it 🙇

@sandrahoang686 sandrahoang686 merged commit c49c3c6 into main Dec 18, 2024
14 checks passed
@sandrahoang686 sandrahoang686 deleted the fix/layer-info-modal-linking branch December 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants